Bump the wire version to 2 for the raw-bytes export download#196
Merged
Conversation
The export endpoint changed shape in #191: the response went from a JSON envelope (base64 data + warnings array) to application/octet-stream with warnings in the X-Volca-Export-Warnings header. That is breaking in both directions — in particular a pyvolca >= 0.7.2 talking to a v0.9.0 engine would save the JSON envelope bytes as the exported file without raising. Bumping currentWireVersion to 2 and REQUIRED_WIRE to 2 turns both stale pairings into a clear signal: a newer client refuses an older engine, an older client warns against a newer engine. MIN_ENGINE_HINT points at v0.9.1, the first release advertising wire 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export endpoint changed shape in #191: the response went from a JSON envelope (base64
data+warningsarray) toapplication/octet-streamwith warnings in theX-Volca-Export-Warningsheader. That is breaking in both directions — in particular pyvolca ≥ 0.7.2 talking to a v0.9.0 engine saves the JSON envelope bytes as the exported file without raising.This bumps
currentWireVersionandREQUIRED_WIREto 2 so both stale pairings get a clear signal instead of silent corruption: a newer client refuses an older engine with an actionable error, an older client warns against a newer engine.MIN_ENGINE_HINTpoints at v0.9.1, the first release that will advertise wire 2. The README compatibility table and its generated block are regenerated, and the compat test's expected downgrade hint updated.Verified: engine builds under
-Werrorwith the full test suite green, and the pyvolca suite passes (187 tests) including the README drift check.