Nebular grid fixes#84
Open
bd-j wants to merge 1 commit into
Open
Conversation
…ular line tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the nebular grids for the PRSC, PDVA, and MIST isochrones. Due to a transcription error when adding columns for new nebular lines, the metallicity and age grid point values of the non-BPASS nebular tables introduced in #70 were incorrect.
Generally, this means that the nebular spectrum returned by
add_nebular.f90was shifted in metallicity and age from the requested values. The shift is small in metallicity (< ~0.1 dex), except at [Fe/H] < -1, where the returned nebular spectrum could have as much as 0.5 dex lower metallicity than requested. The returned nebular spectrum was also for a slightly younger age population (by ~0.2 dex) meaning it would typically be appropriate for a bluer, harder ionizing spectrum. The nebular continuum and nebular line ratios and relative fractions remained consistent with each other (but not necessarily withgas_logzor the age distribution of the stars). The normalization of the line fluxes and nebular continuum remained consistent with the actual number of ionizing photons produced by the stellar model, such that e.g. Balmer line fluxes and equivalent widths were unaffected (modulo the very small effect from the T_e dependence of L_Ha/Q).The changes in this PR are only to data files; they can therefore be incorporated in python-fsps by pointing the
SPS_HOMEenvironment variable to an updated FSPS repository.