Repository navigation
After a crash, Studio's start-up questions come one at a time instead of overlapping - #1341
Merged
Merged
Conversation
… rest?" wait for any open dialog isAnyDialogOpen (themed_confirm.js) sees the themed confirm and any shown .modal window. batch_resume.js waited only for a themed confirm, so after a crash it opened on top of Render Batch Interrupted; it and the render recovery prompt now both wait for any dialog on screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Tested in a real Studio window ( #1340, boot watchdog
#1341, start-up prompts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: after a crash, Studio's start-up questions (recover the render batch, capture the rest) come one at a time instead of on top of each other.
What happened
After the PC froze mid-batch, the next start showed Render Batch Interrupted and "Capture the rest?" at once, one over the other.
"Capture the rest?" (
batch_resume.js) already waited for an open dialog, but only for athemedConfirmone. Render Batch Interrupted is the app's own.modalwindow, shown byrender_pane.js, so it didn't count.What changes
isAnyDialogOpen()inthemed_confirm.js: athemedConfirmdialog, or any.modalwindow on screen.batch_resume.jswaits for it instead ofisThemedConfirmOpen.checkRenderRecoveryOnStartupwaits for it too before showing its window, so the order doesn't matter: whichever comes second waits.Both poll every 500 ms while they wait, as
batch_resume.jsalready did.Test done
dialog_open.test.js(3): a shown window, all hidden, no page.batch_resume.test.jsandthemed_confirm.test.jsunchanged and passing;npm run test:unit(1,421 passed),eslint(no errors), e2erender-studio.spec.jsandapp-boot.spec.js(74 passed).Not tested: a real crash recovery in Studio, where both prompts come up at start.
Your test
Next time Studio starts after a batch or render batch was cut short: the two questions come one after the other.
🤖 Generated with Claude Code