Repository navigation
After a crash, clips that finished rendering come back marked Rendered, not just Captured - #1343
Merged
Merged
Conversation
…ndering, not just Captured The backend already reports a take rendered and deleted while the batch ran (VerifiedBlock.rendered, #861); applyCaughtUpBatch now marks its highlights Rendered instead of Captured, and the toast says how many each way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Tested in a real Studio (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: after Studio or the PC goes down mid-batch, clips that had already finished rendering come back marked Rendered, not just Captured.
What happened
The WSOD25 batch rendered 35 clips while capturing, then the PC froze. On the next start the catch-up marked all 129 captured clips Captured, the 35 finished ones included: their Rendered marks had only been in the open, unsaved project.
What changes
The backend already says when a take was rendered and deleted while the batch ran (
VerifiedBlock.rendered, #861), and nothing read it.applyCaughtUpBatchnow marks those highlights Rendered. The toast says how many each way: "94 highlight(s) marked Captured. 35 highlight(s) marked Rendered: their clips were finished before it closed."Status still only moves forward, with the same rules as before.
Not covered
renderedis only set once a take is gone, so it's still marked Captured. Its render history is in itsdodstudio_take.json, so the backend could check that too; left for a follow-up if wanted.diceWSOD25main.dodstudio's 35: the catch-up ran before this fix and doesn't run again.Test done
batch_catch_up.test.js: a rendered take's highlights become Rendered; the toast counts both ways and leaves Rendered out when there are none (20 pass).npm run test:unit(1,432 passed),eslint(no errors). No e2e spec covers the catch-up.Not tested in Studio: it needs a batch cut short after a render.
🤖 Generated with Claude Code