Repository navigation
Conversation
…th the open and mark their highlights Rendered (#1345) pickUpTakeFolderRenders now resolves { added, takeKeys }. project_session's pickUpRendersOnOpen marks those takes' highlights Rendered (markTakesRendered, take_index.js) and, when the pick-up is the only change since the open, saves quietly. Any other change since the open leaves the project unsaved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: opening a project no longer marks it unsaved when nothing was changed; clips rendered while it was closed come in marked Rendered and saved.
Closes #1345
What happened
Every open of
diceWSOD25main.dodstudiologgedread the render history of 148 take folder(s): 35 video(s) new to the projectand left the project unsaved:pickUpTakeFolderRendersrecorded the renders and marked it dirty, and since the user never saved, it found the same 35 every time. Closing then asked to save changes nobody had made. The same pick-up recorded the renders but left those highlights Captured.What changes
pickUpTakeFolderRendersresolves{ added, takeKeys }instead of a count.project_session.js'spickUpRendersOnOpenmarks those takes' highlights Rendered (markTakesRenderedintake_index.js, the rule a finishing render uses), redraws the tables, and, when the pick-up is the only change since the open, saves the project quietly and logs[project] saved ... with the N video(s) found in its take folders; M highlight(s) now Rendered.main_js_budget525 → 526 for theonStatusChangewiring line.Test done
project_session_open_renders.test.js(3): a project with a new render opens saved with both highlights Rendered; with another change before the pick-up it marks them but writes nothing and stays unsaved; with nothing new it writes nothing.project_renders.test.jsupdated for the new result.npm run test:unit(1,435 passed),eslint(no errors). e2e left to CI: written during a capture batch, kept off heavy runs.Not tested in Studio yet.
Your test (1 min)
Open
diceWSOD25main.dodstudio(its 35 renders aren't in the file yet): the header shows no "• unsaved", and the activity log has thesaved ... found in its take foldersline.🤖 Generated with Claude Code