Skip to content

🐛 Fix wrong label if positive SiDBs occur.#76

Open
Drewniok wants to merge 3 commits into
mainfrom
wrong_operational_status_when_positive_sidbs
Open

🐛 Fix wrong label if positive SiDBs occur.#76
Drewniok wants to merge 3 commits into
mainfrom
wrong_operational_status_when_positive_sidbs

Conversation

@Drewniok
Copy link
Copy Markdown
Collaborator

@Drewniok Drewniok commented Mar 13, 2025 •
edited
Loading

Description

This PR fixes #74. As soon as a positive charge occurs, the gate has to be labeled as non-operational. This should now be fixed.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the bug Something isn't working label Mar 13, 2025
@Drewniok Drewniok self-assigned this Mar 13, 2025
@Drewniok Drewniok changed the title 🐛 set to non-operation if positive charge occur. 🐛 Fix wrong label if positive SiDBs occur. Mar 13, 2025
@Drewniok Drewniok requested a review from marcelwa March 13, 2025 12:10
marcelwa
marcelwa reviewed Mar 14, 2025
View reviewed changes
Comment thread src/mnt/opdom_explorer/gui/widgets/plot_operational_domain_widget.py Outdated
@marcelwa
Copy link
Copy Markdown
Collaborator

marcelwa commented Mar 14, 2025

image
It seems like the X-mark is going missing when we have kinks and an incorrect output signal.

@Drewniok
Copy link
Copy Markdown
Collaborator Author

Drewniok commented Mar 14, 2025

image It seems like the X-mark is going missing when we have kinks and an incorrect output signal.

oh! thanks! I will have a look immediately after having finished something else.

@Drewniok
Copy link
Copy Markdown
Collaborator Author

Drewniok commented Mar 14, 2025

image It seems like the X-mark is going missing when we have kinks and an incorrect output signal.

Sorry, it seems like this is a bug in fiction. I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelwa marcelwa marcelwa left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Drewniok Drewniok

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Positive charges are labled as correct logic output

2 participants

@Drewniok @marcelwa