Remove unused code - #68
Closed
nhaydel wants to merge 2 commits into
Closed
Conversation
SFJohnson24
self-requested a review
June 3, 2024 14:05
Collaborator
|
@nhaydel can you give some context to this--why are we deleting the dataframe type from this repo? Is this associated with an issue? |
Collaborator
@SFJohnson24 I attached the related issue |
gerrycampion
self-requested a review
July 16, 2024 21:09
gerrycampion
left a comment
gerrycampion
left a comment
Collaborator
There was a problem hiding this comment.
Should we do cdisc-org/cdisc-rules-engine#704 before completing this PR?
Author
|
I don't think we need the unit tests before merging this, since we are already using the operators defined in the engine repo |
Collaborator
|
this PR is resolved with #84 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.