Skip to content

Meg train/cg0045/create - #13

Open
Meg-Train wants to merge 3 commits into
mainfrom
Meg-Train/CG0045/create
Open

Meg train/cg0045/create#13
Meg-Train wants to merge 3 commits into
mainfrom
Meg-Train/CG0045/create

Conversation

@Meg-Train

Copy link
Copy Markdown
Collaborator

Hello Els,

This is for the assignment which was part of the CDISC - OPEN CORE Training, the rule CG0045 which we worked on in the training still seems to have issue and isnt working on the positive/negative data but i wanted to check the submission as per the training slides.

Thanks,
Meghna Diedrich.

@Meg-Train
Meg-Train requested a review from eljanssens as a code owner June 30, 2026 14:29
@github-actions

Copy link
Copy Markdown

❌ YAML Format Check Failed

One or more rule.yml files are not correctly sorted/formatted alphabetically by key.

Run the following command locally to fix them:

python scripts/sort_yaml.py

Then commit and push.

@github-actions

Copy link
Copy Markdown

Schema Validation Results

Click to expand

Schema Validation Report

Schema: https://raw.githubusercontent.com/cdisc-org/cdisc-rules-engine/refs/heads/main/resources/schema/rule-merged/CORE-base.json

Files checked: 1 | Failed: 0

Unpublished/NEW-RULE/rule.yml

View workflow run

@github-actions

Copy link
Copy Markdown

Rule Validation Results — NEW-RULE

Click to expand full report

Rule Validation Report

Rule: NEW-RULE
Rule file: /home/runner/work/cdisc-open-rules-training/cdisc-open-rules-training/Unpublished/NEW-RULE/rule.yml

positive

positive/01 — ✅ Results match committed baseline

Engine output for `positive/01`
Output: /home/runner/work/cdisc-open-rules-training/cdisc-open-rules-training/Unpublished/NEW-RULE/positive/01/results/results.json
Wrote 0 rows to /tmp/results_generated_positive_01.csv

negative

negative/01 — ✅ Results match committed baseline

Engine output for `negative/01`
Output: /home/runner/work/cdisc-open-rules-training/cdisc-open-rules-training/Unpublished/NEW-RULE/negative/01/results/results.json
Wrote 0 rows to /tmp/results_generated_negative_01.csv

Summary: 2 passed (Total: 2 test cases)

Full results also available as a workflow artifact.


View workflow run

@Meg-Train Meg-Train self-assigned this Jun 30, 2026
@eljanssens

Copy link
Copy Markdown
Collaborator

Hi Meghna. We did have issues with the training repo not rendering the negative results as expected but normally this should have been fixed. I did try again to see if it still worked. You can see all this in my branch: Els/CG0045/create in PR: #14

What you could do to ensure that your vscode/local repo has all the correct information for the latest engine
git checkout main
git pull origin main
git submodule update --recursive

Then go back to your local branch, delete all the results files and try again running the validation.
It is also worth checking whether the test data are all ok. At first sight, it looks fine but in the env file, you can remove all the rows without a value.

If that doesn't work, then i suggest deleting your branch git branch -D (your branchname) and try again.

My PR also gives a validation failure result
image

I did go back to my local branch and ran the script for sorting, removed it for all other rules (only keep the NEW-RULE file), commit and sync and then the format validation passes
image

I hope this helps. I'm just adding @SFJohnson24 for his awareness, no action needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants