Open
Conversation
🧪 Review environmenthttps://q4jk5h4nmny2dzk5vtacefv2uq0xsdru.lambda-url.ca-central-1.on.aws/ |
andrewleith
commented
Mar 12, 2026
| @@ -0,0 +1,23 @@ | |||
| {% from "components/sms-character-info.html" import sms_character_info %} | |||
Member
Author
There was a problem hiding this comment.
Added a separate storybook page for when the prefix is on.
andrewleith
commented
Mar 12, 2026
| @@ -61,7 +61,11 @@ | |||
| { | |||
Member
Author
There was a problem hiding this comment.
Added the existing page to the menu so we can navigate to it.
jzbahrai
approved these changes
Mar 12, 2026
| it("shows '1 text message.' for 160 GSM chars (1 part)", () => { | ||
| SmsCharacterInfo.typeContent(GSM_1_PART); | ||
| Components.FragmentCountText().should("have.text", "1 text message."); | ||
| describe("Text changes when variables are present", () => { |
Contributor
There was a problem hiding this comment.
im unsure what you did in this file that wasn't being tested before?
Member
Author
There was a problem hiding this comment.
Nothing - I just moved the "UI" tests into cypress and kept the unit tests in Jest. Coverage should be the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This pull request enhances the SMS Character Info component test suite by separating more cleanly the unit and UI tests.
Cypress E2E test improvements:
Jest unit test refactoring:
smsCharacterInfo.test.js, consolidating tests to focus on shared CSV cases and removing manual DOM setup and teardown in favor of more concise, data-driven tests.These changes improve both the developer experience (with clearer stories and more robust tests) and the reliability of the SMS fragment calculation logic, especially in real-world scenarios involving prefixes and personalization variables.
Test instructions | Instructions pour tester la modification