Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a bash script for generating CSV files containing phone numbers for bulk load testing. The script creates files with auto-incrementing timestamped filenames and populates them with a configurable number of phone number entries.
Key Changes:
- Added a new bash script that generates CSV files with phone numbers for performance testing
- Implements filename collision avoidance using timestamps and counters
- Includes progress reporting for long-running operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Default base filename if none provided | ||
| BASE_FILENAME="${1:-phone_numbers}" | ||
| PHONE_NUMBER="+16135550123" |
There was a problem hiding this comment.
[nitpick] The hardcoded phone number should be extracted as a configurable parameter or documented as a test-specific number. This would make the script more flexible for different testing scenarios.
| elif [ "$progress_interval" -lt 1000 ]; then | ||
| progress_interval=1000 |
There was a problem hiding this comment.
When COUNT is less than 10, the progress_interval calculation results in 0, causing a division by zero error at line 68 when checking i % progress_interval == 0. Add a check to ensure progress_interval is at least 1, or skip progress reporting for very small counts.
| elif [ "$progress_interval" -lt 1000 ]; then | |
| progress_interval=1000 | |
| elif [ "$progress_interval" -lt 1 ]; then | |
| progress_interval=1 |
Summary | Résumé
This is just a quick script that will generate bulk load test CSVs.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
N/A
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur