Skip to content

Fix dependency issue #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smcmurtry wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix dependency issue #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ecc7cc
fix dependency issue
smcmurtry Mar 25, 2026
b1143e9
pin the awslambdaric dep
smcmurtry Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ci/Dockerfile.lambda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,12 @@ WORKDIR ${TASK_ROOT}
RUN python -m venv ${POETRY_HOME} \
&& ${POETRY_HOME}/bin/pip3 install poetry==${POETRY_VERSION} virtualenv==20.30.0

COPY pyproject.toml poetry.lock ${TASK_ROOT}/
COPY pyproject.toml poetry.lock README.md ${TASK_ROOT}/

# Install Poetry dependencies first (including setuptools and wheel)
RUN python -m venv ${APP_VENV} \
&& . ${APP_VENV}/bin/activate \
&& poetry install \
&& poetry add awslambdaric wheel
&& poetry install

# Now install NewRelic manually using the setuptools from Poetry
RUN . ${APP_VENV}/bin/activate \
Expand Down
84 changes: 83 additions & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ aws-embedded-metrics = "1.0.8"
aws-xray-sdk = "2.15.0"
# PaaS
awscli-cwlogs = "1.4.6"
awslambdaric = "2.0.1"
boto = "2.49.0"

cachelib = "0.13.0"
Expand All @@ -46,7 +47,6 @@ gunicorn = "23.0.0"
# Pinned dependencies
idna = "3.11" # pinned to align with test moto dependency requirements (for <=2.9)
iso8601 = "2.1.0"
urllib3 = ">=2.6.3,<3" # Pinned this transitive dependency to resolve a number of high security vulnerabilities: https://github.com/cds-snc/notification-api/pull/2806
# REVIEW: v2 is using sha512 instead of sha1 by default (in v1)
itsdangerous = "2.2.0"
jsonschema = "3.2.0"
Expand All @@ -57,11 +57,11 @@ more-itertools = "8.14.0"
nanoid = "2.0.0"
newrelic = "11.5.0"
notifications-python-client = "6.4.1"
notifications-utils = { git = "https://github.com/cds-snc/notifier-utils.git", tag = "53.2.20"}
opentelemetry-instrumentation-celery = "0.55b1"
opentelemetry-instrumentation-flask = "0.55b1"
opentelemetry-instrumentation-redis = "0.55b1"
opentelemetry-instrumentation-sqlalchemy = "0.55b1"
notifications-utils = { git = "https://github.com/cds-snc/notifier-utils.git", tag = "53.2.20"}
pre-commit = "^3.7.1"
psycopg2-binary = "2.9.11"
pwnedpasswords = "2.0.0"
Expand All @@ -78,6 +78,7 @@ types-psycopg2 = "^2.9.21.20250516"
# rsa = "4.9 # awscli 1.22.38 depends on rsa<4.8
typing-extensions = "4.15.0"
unidecode = "1.4.0"
urllib3 = ">=2.6.3,<3" # Pinned this transitive dependency to resolve a number of high security vulnerabilities: https://github.com/cds-snc/notification-api/pull/2806
# Putting upgrade on hold due to new version introducing breaking changes
Werkzeug = "3.0.6"

Expand Down
Loading