Open
Conversation
672b24d to
bc9f416
Compare
bc9f416 to
607d4ef
Compare
66abeaf to
581168e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new message_parts() method to the SMSMessageTemplate class that returns detailed SMS fragment information including character count, fragment count, and unicode characters. It also fixes a typo in the FRENCH_NON_GSM_CHARACTERS constant name and updates the unicode detection to include French characters.
Changes:
- Added
message_parts()method to return SMS message details (character count, fragments, unicode chars) - Fixed typo:
FRENCH_NON_GSM_CHARACTESR→FRENCH_NON_GSM_CHARACTERS - Updated unicode detection to include both Welsh and French non-GSM characters
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_template.py | Added comprehensive test suite for the new message_parts() method covering various scenarios |
| notifications_utils/template.py | Implemented message_parts() method and updated unicode detection logic |
| notifications_utils/sanitise_text.py | Fixed typo in FRENCH_NON_GSM_CHARACTERS constant name |
| pyproject.toml | Bumped version from 53.2.13 to 53.2.14 |
| .github/actions/waffles/requirements.txt | Updated dependency reference to version 53.2.14 |
| .devcontainer/Dockerfile | Updated base image to specify bookworm variant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Update the the template calculation to return all the different message part details:
fragments
Related Issues | Cartes liées
https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/2939
Test instructions | Instructions pour tester la modification
added tests
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur