Conversation
…49) TRUSTED_PROXY_IPS was never copied from MONITOR_APP into CONF["APP"], so login-by-ip always used the compile-time defaults (127.0.0.1/::1). Under Docker, Traefik connects from a dynamic container IP (172.x), which is not in the defaults — X-Forwarded-For was ignored and the dashboard returned 401 for every auto-login attempt. - config_loader: copy TRUSTED_PROXY_IPS to CONF["APP"] - client_ip: TrustedProxySet precompiles CIDR networks via ipaddress so ranges like 172.16.0.0/12 match without listing every container IP - 13 tests covering literals, CIDR IPv4/IPv6, mixed, and edge cases
Contributor
Release PR — merge methodCommits listed on this PR: 1 (file diff may be smaller — that is normal when squash releases stacked up). RequiredMerge with Create a merge commit. Do not use Squash and merge. Why
One-time cleanupIf this PR lists commits from earlier releases (2.0.4, 2.0.5, …), merge once with merge commit; post-release sync realigns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary