Conversation
Self-service page now fetches logged-in devices from the DB on every
load instead of using the stale int_ids cached in the session cookie.
- GET /api/self-service/devices queries DB (by callsign for password
login, by client IP for auto-login)
- Migrate all self-service routes to strict REST (/devices, /devices/{id},
/devices/{id}/modified)
- Add login_method to UserSession (signed cookie, tamper-proof)
- Remove dead code: allows_int_id, select_device, require_session_user alias
- Extract client_ip_from_request helper to deduplicate auth/self_service
fix: live device list and REST self-service endpoints
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34488956 | Triggered | Generic Password | a87f491 | monitor/tests/test_self_service_use_cases.py | View secret |
| 34488956 | Triggered | Generic Password | 9ce0711 | monitor/tests/test_self_service_use_cases.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
Release PR — merge methodCommits listed on this PR: 2 (file diff may be smaller — that is normal when squash releases stacked up). RequiredMerge with Create a merge commit. Do not use Squash and merge. Why
One-time cleanupIf this PR lists commits from earlier releases (2.0.4, 2.0.5, …), merge once with merge commit; post-release sync realigns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary