Skip to content

fix(ci): make release workflow tag-only safe #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ceastld merged 2 commits into from
Aug 20, 2026
Merged

fix(ci): make release workflow tag-only safe #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c75a6
fix(ci): make release workflow tag-only safe
cursoragent Aug 20, 2026
1188081
fix(app): harden release signing fallback
cursoragent Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ concurrency:

jobs:
release:
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -47,13 +48,22 @@ jobs:
uses: android-actions/setup-android@v3

- name: Decode release keystore
if: ${{ secrets.SIGNING_KEYSTORE_BASE64 != '' }}
env:
SIGNING_KEYSTORE_BASE64: ${{ secrets.SIGNING_KEYSTORE_BASE64 }}
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_STORE_PASSWORD }}
SIGNING_KEY_ALIAS: ${{ secrets.SIGNING_KEY_ALIAS }}
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
run: |
echo "${{ secrets.SIGNING_KEYSTORE_BASE64 }}" | base64 -d > "${RUNNER_TEMP}/timesense.jks"
if [[ -z "${SIGNING_KEYSTORE_BASE64}" ]]; then
echo "No release keystore configured; Gradle will use the debug signing fallback."
exit 0
fi

echo "${SIGNING_KEYSTORE_BASE64}" | base64 -d > "${RUNNER_TEMP}/timesense.jks"
echo "TIMESENSE_KEYSTORE=${RUNNER_TEMP}/timesense.jks" >> "$GITHUB_ENV"
echo "TIMESENSE_STORE_PASSWORD=${{ secrets.SIGNING_STORE_PASSWORD }}" >> "$GITHUB_ENV"
echo "TIMESENSE_KEY_ALIAS=${{ secrets.SIGNING_KEY_ALIAS }}" >> "$GITHUB_ENV"
echo "TIMESENSE_KEY_PASSWORD=${{ secrets.SIGNING_KEY_PASSWORD }}" >> "$GITHUB_ENV"
echo "TIMESENSE_STORE_PASSWORD=${SIGNING_STORE_PASSWORD}" >> "$GITHUB_ENV"
echo "TIMESENSE_KEY_ALIAS=${SIGNING_KEY_ALIAS}" >> "$GITHUB_ENV"
echo "TIMESENSE_KEY_PASSWORD=${SIGNING_KEY_PASSWORD}" >> "$GITHUB_ENV"

- name: Assemble release
run: |
Expand Down
12 changes: 7 additions & 5 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ plugins {

val ciVersionName = (findProperty("versionName") as String?)?.takeIf { it.isNotBlank() }
val ciVersionCode = (findProperty("versionCode") as String?)?.toIntOrNull()
val keystorePath = System.getenv("TIMESENSE_KEYSTORE").orEmpty()
fun nonBlankEnv(name: String): String? = System.getenv(name)?.takeIf { it.isNotBlank() }

val keystorePath = nonBlankEnv("TIMESENSE_KEYSTORE").orEmpty()
val releaseKeystore = keystorePath.takeIf { it.isNotBlank() }?.let { file(it) }?.takeIf { it.isFile }

android {
Expand All @@ -25,10 +27,10 @@ android {
if (releaseKeystore != null) {
create("release") {
storeFile = releaseKeystore
storePassword = System.getenv("TIMESENSE_STORE_PASSWORD") ?: ""
keyAlias = System.getenv("TIMESENSE_KEY_ALIAS") ?: "upload"
keyPassword = System.getenv("TIMESENSE_KEY_PASSWORD")
?: System.getenv("TIMESENSE_STORE_PASSWORD")
storePassword = nonBlankEnv("TIMESENSE_STORE_PASSWORD") ?: ""
keyAlias = nonBlankEnv("TIMESENSE_KEY_ALIAS") ?: "upload"
keyPassword = nonBlankEnv("TIMESENSE_KEY_PASSWORD")
?: nonBlankEnv("TIMESENSE_STORE_PASSWORD")
?: ""
}
}
Expand Down
Loading