Apply some minor generator optimizations - #998
Open
john-h-kastner-aws wants to merge 1 commit into
Open
Conversation
Signed-off-by: jkastner <jkastner@amazon.com>
| /// get a purely arbitrary string constant with that maximum size | ||
| /// indicated by `bound`. May truncate a longer string in the pool to this | ||
| /// length. | ||
| pub fn arbitrary_string_constant_bounded( |
Contributor
Author
There was a problem hiding this comment.
This is a behavior change in addition to optimization. The function now takes an arbitrary string from the constant pool and truncates it the max length. IMO this is good because it lets this get more variety while still drawing from the constant pool
Member
There was a problem hiding this comment.
Isn't also generating fresh string constants from time to time also desirable?
| /// list of EntityUIDs that exist as a non-`None` actions name for an action in | ||
| /// the schema. | ||
| pub actions_eids: Vec<ast::Eid>, | ||
| pub actions_euids: Vec<ast::EntityUID>, |
Contributor
Author
There was a problem hiding this comment.
We only ever used this for EntityUIDs, so this change is to construct it as those instead of as Eids
victornicolet
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: