Skip to content

add readOnly and canRequestFocus properties#335

Merged
cedvdb merged 5 commits intocedvdb:mainfrom
ArAmM7:main
Dec 10, 2025
Merged

add readOnly and canRequestFocus properties#335
cedvdb merged 5 commits intocedvdb:mainfrom
ArAmM7:main

Conversation

@ArAmM7
Copy link
Contributor

@ArAmM7 ArAmM7 commented Dec 10, 2025

Checklist

  • I have bumped the version in pubspec.yaml
  • I have added an entry in changelog.md for the new pubspec version
  • (not required if no sensible change has been made eg: Localization) I have added tests that prove my fix is effective or that my feature works.

Copilot AI review requested due to automatic review settings December 10, 2025 12:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two new properties to the PhoneFormField widget to provide better control over the text input behavior: readOnly and canRequestFocus. These properties are passed through to the underlying TextField widget, allowing users to make the phone input read-only or prevent it from receiving focus.

  • Added readOnly property with default value false to control whether the field accepts text input
  • Added canRequestFocus property with default value true to control whether the field can receive focus
  • Version bumped from 10.0.14 to 10.0.15 with corresponding changelog entries

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/src/phone_form_field.dart Declared the two new boolean properties readOnly and canRequestFocus with appropriate default values
lib/src/phone_form_field_state.dart Passed the new properties through to the underlying TextField widget
test/phone_form_field_test.dart Added comprehensive test coverage for both properties, including property verification and behavioral tests
pubspec.yaml Bumped version from 10.0.14 to 10.0.15
CHANGELOG.md Added entries documenting the new properties for version 10.0.15

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cedvdb cedvdb merged commit 11dfb48 into cedvdb:main Dec 10, 2025
7 checks passed
@cedvdb
Copy link
Owner

cedvdb commented Dec 10, 2025

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants