add readOnly and canRequestFocus properties#335
Merged
cedvdb merged 5 commits intocedvdb:mainfrom Dec 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds two new properties to the PhoneFormField widget to provide better control over the text input behavior: readOnly and canRequestFocus. These properties are passed through to the underlying TextField widget, allowing users to make the phone input read-only or prevent it from receiving focus.
- Added
readOnlyproperty with default valuefalseto control whether the field accepts text input - Added
canRequestFocusproperty with default valuetrueto control whether the field can receive focus - Version bumped from 10.0.14 to 10.0.15 with corresponding changelog entries
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/phone_form_field.dart | Declared the two new boolean properties readOnly and canRequestFocus with appropriate default values |
| lib/src/phone_form_field_state.dart | Passed the new properties through to the underlying TextField widget |
| test/phone_form_field_test.dart | Added comprehensive test coverage for both properties, including property verification and behavioral tests |
| pubspec.yaml | Bumped version from 10.0.14 to 10.0.15 |
| CHANGELOG.md | Added entries documenting the new properties for version 10.0.15 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist