chore: update .gitignore for bun lockfiles and addon/data#420
chore: update .gitignore for bun lockfiles and addon/data#420YagUber wants to merge 2 commits intocedya77:devfrom
Conversation
|
Hold on- Have been digging around the project some more, It was added in c0737f0 but yet the current dev branch is completely missing implementations for addCorrection/loadCorrections/removeCorrections, and since its a lot of the code is native JS (including the configApi that uses it) this was never caught. Dev is also missing other stuff from your testing branch that the aforementioned commit came from that seems pretty useful, like some additional .md docs. I'm not going to pretend I understand whats going on here, but this should probably be investigated. Additionally addon/* should probably be migrated to TS (and away from CJS) so things like this are much easier to catch in the future. That is something I can do, but I will await permission before making a larger PR for something like this. The whole TS/CJS also kind of confuses me here as well... the npm scripts are mixed TS/JS. Is this intentional? Even the vercel.json example is attempting to start the server from addon/server.js which doesn't exist, and its TS counterpart is never compiled with tsc in the first place to be able to run? No clue whats going on there. Note: I discovered this while going through all of the dependencies of this project, a fair amount of which are completely unused, extremely outdated like country-iso-2-to-3 that should be replaced by i18n-iso-countries, (or others such as fanart.tv-api, which fanart themselves have released an official drop-in replacement for called @fanart-tv/api). I'm going to hold off on that PR for now, because this is already some bad code smell. |
|
Addressed by #423 |
Summary
Updates
.gitignoreto ignore Bun lockfiles and runtime generated files inaddon/data/, while keepingid-mapping-corrections.jsontracked.Changes
bun.lockbandbun.lockto ignored filesaddon/data/*but allowlistaddon/data/id-mapping-corrections.json