Validate invalid Stellar address edge cases#465
Open
Gezziy wants to merge 1 commit into
Open
Conversation
|
@Gezziy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #432
##Summary of Changes
Added shared Stellar Ed25519 public key validation using the official Stellar SDK StrKey.isValidEd25519PublicKey.
Added invalid address edge-case tests for empty, padded, lowercase, bad-checksum, S..., M..., C..., and non-string values.
Applied validation to SEP-24 deposit/withdraw account inputs.
Reused the shared validator in batch and recurring payment flows.
Prevented invalid address values from being echoed in validation errors.
Fixed malformed backend tsconfig.json so targeted tests can run.
##Reason for Changes
This addresses QA issue #432 by ensuring invalid Stellar addresses are rejected consistently and safely across relevant backend payment boundaries before testnet deployment.