feat(sep6): add SEP-6 withdrawal endpoint with fee calculation#477
Merged
Ceejaytech25 merged 1 commit intoMay 29, 2026
Merged
Conversation
- Add fee calculation via computeAssetFee (flat/percentage/tiered) - Accept account, callback_url, and lang query params per SEP-6 spec - Persist receiverInfo JSON, callbackUrl, feeAmount, feeAssetCode, feeType - Return fee_amount and amount_out (net of fee) in every response - Replace console.error with structured logger; mask error details - Update withdrawQuerySchema with new optional fields - Add 13 new withdrawal tests covering fees, receiverInfo, callbackUrl, amount boundaries, NaN, crypto type, and downstream DB errors Fixes ceejaylaboratory#374
|
@Damola09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the SEP-6 non-interactive withdrawal endpoint as specified in issue #374.
account,amount,asset_code,type,dest,dest_extra,callback_url,langquery parametersfee_amountandamount_outusingcomputeAssetFeefrom the fee servicereceiverInfo,callbackUrl,feeAmount,feeAssetCode, andfeeTypeon the transaction recordfee_amount,amount_out, andtypein the JSON responseTest plan
fee_amountandamount_outin the responsereceiverInfoandcallbackUrlon the transactionFixes #374