feat(sep1): add Redis caching strategy for SEP-1 info responses#480
Merged
Ceejaytech25 merged 1 commit intoMay 29, 2026
Merged
Conversation
- Add src/services/sep1-info-cache.service.ts:
- TTL: 5 min, stale-while-revalidate grace: 60 s
- getOrCompute(): cache-aside with background refresh on stale hit
- Graceful Redis failure: swallows errors, always falls back to computeFn
- invalidate(): explicit cache bust for config/asset changes
- Static accessors (cacheKey, ttlSeconds, staleGraceSeconds) for tests
- Refactor info.controller.ts:
- Extract buildStellarInfo() for reuse by cache compute function
- Make getInfo() async; serve response via sep1InfoCache.getOrCompute()
- Redis unavailability is non-fatal; endpoint always returns a response
- Update info.controller.test.ts: await async getInfo() in all existing tests
- Add sep1-info-cache.service.test.ts: 18 unit tests covering cold miss,
fresh hit, stale-while-revalidate, full expiry, Redis failures (get/set/del),
TTL write, and invalidation
Fixes ceejaylaboratory#368
|
@Damola09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Redis-backed cache for the SEP-1 anchor info endpoint as specified in issue #368.
Test plan
Fixes #368