fix: add shared Nodemailer SMTP service for backend email delivery#489
Merged
Conversation
Centralize SMTP transport setup and wire admin password resets, notification emails, and hot-wallet alerts through it. Closes ceejaylaboratory#364
|
@wheval Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shared Nodemailer SMTP transport for backend email delivery and wires existing email flows through it.
Purpose / Motivation
Issue #364 is part of the testnet readiness wave. The backend previously created ad-hoc Nodemailer transports and logged alert emails instead of sending them. This change centralizes SMTP configuration so password resets, notifications, and hot-wallet alerts can use the same transport.
Changes Made
backend/src/lib/smtp.service.tsas the shared Nodemailer transport with safe logging when SMTP is not configuredadmin-email.service.tsto use the shared SMTP serviceSmtpEmailProviderand auto-selects it when SMTP env vars are present.env.exampleand backend READMEHow to Test
SMTP_HOST,SMTP_PORT,SMTP_FROM, optional auth) and restart the backend.ALERT_EMAIL_RECIPIENTSconfigured.Breaking Changes
Related Issues
Closes #364
Checklist