Benchmark: sentry PR 80168 - #12
Open
celmis-codereviewer wants to merge 2 commits into
Open
Conversation
… stateful detector This adds a hook that can be implemented to produce an occurrence specific to the detector that is subclassing the StatefulDetector. Also change the signature of evaluate to return a dict keyed by groupkey instead of a list. This helps avoid the chance of duplicate results for the same group key.
celmis-codereviewer
left a comment
celmis-codereviewer
left a comment
Author
There was a problem hiding this comment.
💬 COMMENT — findings to consider
Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
celmis-codereviewer
left a comment
celmis-codereviewer
left a comment
Author
There was a problem hiding this comment.
✅ APPROVED — no blocking findings
Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.
Author
🤖 Code Review for PR #12✅ APPROVED — no blocking findings No issues detected. Scope
Performance
Powered by Code Analyzer · context: tree-sitter graph + structural, cve, security, contract, defect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark reproduction of getsentry#80168