Fix inSchool alignment boundary solution issues#339
Fix inSchool alignment boundary solution issues#339LiangShi369 wants to merge 3 commits intoMV-fix-edu-modulefrom
Conversation
|
I tried running the simulation without "fix 3", and the alignment looks very good. In fact, the parameter MAX_AGE_TO_ENTER_EDUCATION is no longer used in the simulation. In our do files (Box\CeMPA shared area_SimPaths_SimPathsUK\input data preparation_Darias backup folder_keep for now\regression_estimates\do), the probability of returning education if condition does not rule out people whose age are greater than MAX_AGE_TO_ENTER_EDUCATION. |
|
@dariaple and @ANBurdett can confirm, but I recall that the removal of max age from the filtering conditions of returning to education was intentional. |
Previously this branch is called "education alignment", however, it is dedicated to "in school alignment" as defined by
private boolean alignInSchool = true; //Set to true to align share of students among 16-29 age groupin the SimPathsModel class.
I made following fixes:
evaluate(double[] args), each person is reset to Les_c4_lag1 before callingperson.inSchool(args[0]). This prevents the previous trial state (in root finding) to contaminate the current trial.if (demAge > MAX_AGE_TO_ENTER_EDUCATION) return false;, hence person with age >= 29 would not return to education. Perhaps we can revise the relevant flowchart.I think this warm-start (suggested by Codex) is a good strategy in general, so I added it to the employment alignment pull request (Addressed boundary solution issues in UK employment alignment #333 ).
I also added some diagnotics to show the root finding process during the alignment.