Qualify the 0.24.0 test-suite speedup — 2.6x was an idle-machine number - #21
Merged
Merged
Conversation
- Updated changelog.mdx Mintlify-Source: dashboard-editor
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction to a performance claim in the 0.24.0 changelog entry. Mirrors cfdude/pm#74.
"~118s to ~46s" is reproducible, but only on an otherwise-idle 16-core workstation. Presenting it without conditions overstates what most readers will see.
Measured across three environments:
Parallel execution is exactly what degrades when cores are already contended, so the benefit largely evaporates on a busy laptop or a few-core runner — which is what CI is.
The headline now says the suite "runs in parallel" rather than quoting a single number, with the range and its conditions given underneath. The structural claims are unchanged and still verifiable: 11 files, 676 engine spawns at ~73ms each,
node --testparallelizes across files only, split verified by test-name-set equality.Mintlify
0 threads from 0 users in Mintlify