Skip to content

Use of lists for year in radas_config is confusing #32

Description

@tbody-cfs

I think this is hard to read because it's parsing certain config with conventions that aren't clear from the names. I'm confused by file_to_read being an int or a list, I'd expect a filename.

Probably a dataclass or a pydantic class (if we're willing to add the dependency) would make this more readable. But that may be out of scope for now.

Originally posted by @MishaVeldhoen in #31 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions