Simplify initialization code by removing redundant operations#47
Merged
cfuehrmann merged 2 commits intomainfrom Oct 6, 2025
Merged
Simplify initialization code by removing redundant operations#47cfuehrmann merged 2 commits intomainfrom
cfuehrmann merged 2 commits intomainfrom
Conversation
Directory is guaranteed to exist after create_data_files succeeds
Use template constants directly instead of wrapper functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies initialization code by removing redundant operations and unnecessary wrapper functions.
Changes
create_dir_all: Directory is guaranteed to exist aftercreate_data_filessucceedsRationale
Directory Creation:
The
create_schemasfunction is called aftercreate_data_filesin the initialization flow. Sincecreate_data_fileswrites files directly to the output directory, the directory must already exist for those writes to succeed.Template Accessors:
The
get_recipe_template()andget_ingredient_template()functions were simple wrappers around constants with no additional logic, making them unnecessary indirection.Benefits
All 36 tests pass, confirming no behavioral changes.