Require compile context for clang-tidy#25
Merged
Conversation
Summary Require generic C/C++ compile context before Checkrun plans or runs `clang-tidy`. `.clang-tidy` configures rule selection, but it does not provide the compiler arguments needed for a meaningful standalone `clang-tidy` invocation. Treating it as an enablement signal made Checkrun run raw `clang-tidy` in repos that provide their C++ compiler context through another toolchain. - use `compile_commands.json` and `compile_flags.txt` as the `clang-tidy` registry gate - keep `.clang-tidy` as an optional `--config-file` when compile context exists - update fast lint and verify-time adapters to share the same rule - cover `.clang-tidy`-only, compile-database, compile-flags, and combined config cases Testing - `./bin/checkrun format README.md lib/checkrun/verify.py lib/checkrun/linters/languages.sh share/checkrun/registry.json test/suites/autolint-test test/suites/registry-test test/suites/verify-test` - `./bin/checkrun lint README.md lib/checkrun/verify.py lib/checkrun/linters/languages.sh share/checkrun/registry.json test/suites/autolint-test test/suites/registry-test test/suites/verify-test` - `test/suites/registry-test` - `test/suites/verify-test` - `test/suites/autolint-test` - `test/checkrun-test`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require
clang-tidyto have generic C/C++ compile context before Checkrun plans or runs it..clang-tidyconfigures rule selection, but it does not provide compiler arguments. The registry now gatesclang-tidyoncompile_commands.jsonorcompile_flags.txt, while fast lint and verify still pass nearby.clang-tidyas--config-fileafter compile context exists.Testing:
./bin/checkrun format README.md lib/checkrun/verify.py lib/checkrun/linters/languages.sh share/checkrun/registry.json test/suites/autolint-test test/suites/registry-test test/suites/verify-test./bin/checkrun lint README.md lib/checkrun/verify.py lib/checkrun/linters/languages.sh share/checkrun/registry.json test/suites/autolint-test test/suites/registry-test test/suites/verify-testtest/suites/registry-testtest/suites/verify-testtest/suites/autolint-testtest/checkrun-test