Make verify._merge_rc severity-aware#28
Merged
Merged
Conversation
Summary mirror autolint's `_autolint_merge_rc` policy in the Python `_merge_rc` so structural exit codes (2, or the unknown-adapter sentinel 125) survive later ordinary findings. Previously the first non-zero code won, so in a multi-tool run a later 125/2 was masked by an earlier 1 — a failing run pointed at an ordinary diagnostic instead of the broken Checkrun contract. Now 125 outranks 2 outranks any other non-zero, matching the shell side. Testing - checkrun test suite: all suites pass (verify-test 108) - new verify-test case asserts the precedence table (1|2->2, 1|125->125, 2|125->125, 1|1->1, and clean-code passthrough) - checkrun lint clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror autolint's
_autolint_merge_rcpolicy in the Python_merge_rcso structural exit codes (2, or the unknown-adapter sentinel 125) survive later ordinary findings. Previously the first non-zero code won, so a later 125/2 was masked by an earlier 1. Now 125 outranks 2 outranks any other non-zero, matching the shell side. Adds a verify-test case asserting the precedence table.