Derive Sley dirty state from counts#13
Merged
Merged
Conversation
Summary Separate Sley's dirty-state decision from the display JSON string emitted by `status`. Dirty state is now derived from numeric staged/pending/unstaged/ untracked counts before rendering JSON, so field order or formatting changes cannot affect control flow. Add focused coverage for the count-to-dirty helper to lock in the machine semantics directly. Testing - `shellcheck lib/sley/sley.sh test/suites/sley-behavior-test` - `bash test/suites/sley-behavior-test`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive Sley's dirty-state decision from numeric change counts instead of from
the rendered status JSON string. This keeps machine semantics separate from
display formatting, so changing JSON field order or whitespace cannot change
whether a repo is considered dirty.
Summary
dirtyfrom staged/pending/unstaged/untracked numeric countsTesting
shellcheck lib/sley/sley.sh test/suites/sley-behavior-testbash test/suites/sley-behavior-test