Skip to content

Fix diagnostic feedback and reconcile API documentation - #4

Merged
cguodesign merged 1 commit into
mainfrom
codex/fix-api-docs-audit
Oct 28, 2026
Merged

cguodesign merged 1 commit into
mainfrom
codex/fix-api-docs-audit

Conversation

@cguodesign

@cguodesign cguodesign commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

An invalid or clamped markStyle could report the same diagnostic on every React commit. An onIssue callback that stores that diagnostic in state then sustained a feedback loop even though the overlay rendered only once. Compare snapshots of the raw style fields before normalizing again, including NaN and malformed JavaScript values; changed inputs, in-place edits and valid-to-invalid recovery still report correctly.

Also preserve the first editorial animation when an earlier unsupported scene contained no drawable marks.

Align the website's five-language lifecycle, measurement, scheduling and CSS-variable guidance with the implementation. Correct wrapped-renderer error and conditional overlay-preservation descriptions across the public guides and agent discovery files. Bounds-valid offsets are not automatically diagnosed as semantically stale. Record these fixes under Unreleased; no package was published or site deployed.

Validation:

  • New diagnostic regressions first reproduced the state loop, then passed; 28 targeted unit tests and the new first-visible-animation browser regression pass.
  • The original browser reproduction now settles at one diagnostic, two host renders and one overlay render, rather than 12 repeated diagnostics.
  • Ten copied complete Get started examples pass strict typechecks and browser mounting; all 12 docs TS/TSX fragments typecheck with explicit host context. Copied vanilla lifecycle and helpers examples execute successfully.
  • Independent review mapped all 16 English docs sections to source/evidence and rechecked the corrected five-language API semantics. This is not a claim of independent native-speaker certification or exhaustive input/browser coverage.
  • Final local and Linux verify:release passed: 183 unit tests, 159 browser tests, 11 built-site tests, all five fresh consumers, builds, typechecks, security/docs/package/bundle audits, and diff checks. No failure annotations. Linux run: https://github.com/cguodesign/proofmarks/actions/runs/40636778336 .

@cguodesign
cguodesign merged commit 38217e0 into main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant