Repository navigation
Fix diagnostic feedback and reconcile API documentation - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An invalid or clamped markStyle could report the same diagnostic on every React commit. An onIssue callback that stores that diagnostic in state then sustained a feedback loop even though the overlay rendered only once. Compare snapshots of the raw style fields before normalizing again, including NaN and malformed JavaScript values; changed inputs, in-place edits and valid-to-invalid recovery still report correctly.
Also preserve the first editorial animation when an earlier unsupported scene contained no drawable marks.
Align the website's five-language lifecycle, measurement, scheduling and CSS-variable guidance with the implementation. Correct wrapped-renderer error and conditional overlay-preservation descriptions across the public guides and agent discovery files. Bounds-valid offsets are not automatically diagnosed as semantically stale. Record these fixes under Unreleased; no package was published or site deployed.
Validation:
verify:releasepassed: 183 unit tests, 159 browser tests, 11 built-site tests, all five fresh consumers, builds, typechecks, security/docs/package/bundle audits, and diff checks. No failure annotations. Linux run: https://github.com/cguodesign/proofmarks/actions/runs/40636778336 .