node,enr: optional handshake ENR and WHOAREYOU enr-seq#31
Merged
Conversation
WHOAREYOU enr-seq reflects the cached initiator ENR sequence (0 if none). Pending challenges store a dup of that ENR for verify when the handshake omits the record. Initiator omits the record only when challenge seq matches its current ENR seq and seq is non-zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes discv5 handshake behavior around omitted
recordand correct WHOAREYOUenr-seq.enr-seqis 0 when the responder has no cached ENR for the initiator; otherwise the sequence from the cached record (enr.recordSequenceFromRaw).recordon the wire only whenenr-seq != 0and matches the node’s current ENR sequence.recordwhen pending state holds a dup of the initiator ENR used for that challenge; verifies andrememberPeerRecordas before.recordSequenceFromRawasserted in ENR roundtrip.Closes #20 (if that issue tracked this work).