discv5: experimental topic wire flag, CI, manual v0.1.0 release#35
Merged
Conversation
- Add -Dexperimental_topic_wire (default true); when false, decodePlaintext rejects 0x07-0x0a and wire.MessageKind.parse hides those kinds. - Tests: skip topic roundtrip when off; assert UnknownKind when off. - CI: format + tests on main PR/push, including experimental_topic_wire=false. - Release: workflow_dispatch creates GitHub Release; verifies tag matches build.zig.zon version (default v0.1.0). - README: document option and workflows; gitignore zig-pkg/. Closes #24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #24
Non-final topic advertisement wire (REGTOPIC / TICKET / REGCONFIRMATION / TOPICQUERY) is now controlled by a build option:
-Dexperimental_topic_wire(default true): current behavior — decode accepts 0x07–0x0a;wire.MessageKind.parserecognizes those kinds.-Dexperimental_topic_wire=false: inbounddecodePlaintextreturnsUnknownKindfor experimental types;MessageKind.parsereturnsnullfor 0x07–0x0a. Encode helpers remain available for tooling.CI
.github/workflows/ci.yml— on push/PR tomain:zig fmt --check,zig build test, and tests with experimental topic wire disabled.Release
.github/workflows/release.yml— workflow_dispatch with tag input (defaultv0.1.0). Verifies the tag (withoutv) matchesbuild.zig.zonversion, runs the same checks as CI, then creates a GitHub Release with generated notes.Also:
zig-pkg/in.gitignorefor stray local package trees.Closes #24.