Cron agent with price momentum and portfolio info#93
Merged
Conversation
…in-ml/alphaswarm into research-cron-momentum-agent
Winston-503
reviewed
Feb 21, 2025
Comment on lines
+187
to
+191
| token_addresses = [ | ||
| "0x4F9Fd6Be4a90f2620860d680c0d4d5Fb53d1A825", # AIXBT | ||
| "0x0b3e328455c4059EEb9e3f84b5543F74E24e7E1b", # VIRTUAL | ||
| "0x731814e491571A2e9eE3c5b1F7f3b962eE8f4870", # VADER | ||
| ] |
Contributor
There was a problem hiding this comment.
Could read from config with GetTokenAddress but that's good enough for now
Contributor
There was a problem hiding this comment.
I was also thinking it could be cool to just use the intersection of tokens in the wallet and supported ones in the config (or whatever else is determining the universe of tradable tokens) -- but agree I think this is fine for now.
Co-authored-by: Nikolaiev Dmytro <nikolaevdmitryprog@gmail.com>
…in-ml/alphaswarm into research-cron-momentum-agent
…in-ml/alphaswarm into research-cron-momentum-agent
aflament
requested changes
Feb 21, 2025
Comment on lines
+124
to
+127
| "```csv", | ||
| "symbol,address,amount", | ||
| *[f"{token.token_info.symbol},{token.token_info.address},{token.value}" for token in tokens], | ||
| "```", |
Contributor
There was a problem hiding this comment.
I could implement a toCsv on PortfolioBalance
| f" - {self.long_term_periods * 5}min change: {long_term_change:.2f}%\n" | ||
| ) | ||
|
|
||
| def calculate_price_changes(self, prices: List[Decimal]) -> Tuple[Decimal, Decimal]: |
Contributor
There was a problem hiding this comment.
Would prefer an object, to avoid any confusion.
@dataclass
class PriceChange:
short_term: Decimal
long_term: Decimal
@classmethod
def null() -> PriceChange:
return PriceChange(..)
def is_above_threshold(short, long) -> bool:
....
@classmethod
def from_prices(prices: Sequence[Decimal], *, short_period, long_period) -> PriceChange:
....
Contributor
Author
There was a problem hiding this comment.
@aflament good point, updated according to your suggestions
aflament
reviewed
Feb 21, 2025
aflament
reviewed
Feb 21, 2025
aflament
approved these changes
Feb 21, 2025
Contributor
|
@zikunukiz approved, but: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example agent that: