feat(chelm): make the test org path and per-case registry configurable - #477
Merged
Merged
Conversation
charts whose templates treat a dotted first path segment as a registry hostname silently drop the registry, and repository paths beginning with a domain name are common in practice. the hardcoded, dot-free `chainguard/test` hid that from every chart under test. `--test-repository` makes the path a flag; the default is unchanged, since flipping it will legitimately fail charts carrying that heuristic. `test.cases[].registry` is the registry a case's images must resolve under, so a case that sets a chart's registry override in `values` can assert it took effect instead of rendering the same refs as the case without it.
joshrwolf
force-pushed
the
chelm-dotted-org
branch
from
September 4, 2026 20:39
033606e to
207974a
Compare
jdolitsky
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chelm testrendered every chart against a hardcoded, dot-free repository path (chainguard/test). a chart whose templates treat a dotted first path segment as a registry hostname will silently drop the registry, and repository paths beginning with a domain name are common in practice — so those charts render pullable refs underchelm testand unpullable ones for real inputs.--test-repositorymakes the path configurable. the default is unchanged for now: flipping it will legitimately fail charts carrying that heuristic, so it needs a sweep first.test.cases[].registryis the registry a case's images must resolve under, defaulting to--test-registry. a case that sets a chart's global registry override invaluescan now assert the override actually took effect, rather than rendering the same refs as the case without it. the repository prefix stays fixed across cases, so an override that stacks onto the host already in the ref — or swallows the first path segment along with it — is rejected too.