Skip to content

perf: check manifests concurrently in scan.Dir #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algomaster99 merged 1 commit into from
Sep 1, 2026
Merged

perf: check manifests concurrently in scan.Dir #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions pkg/scan/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"os"
"path/filepath"
"sort"
"sync"

"github.com/chains-project/yul/pkg/util/manifestchecker"
"github.com/chains-project/yul/pkg/util/mismatch"
Expand Down Expand Up @@ -124,16 +125,29 @@ func Dir(root string, checkers []manifestchecker.ManifestChecker) ([]Finding, er
return nil, err
}

var findings []Finding
var (
wg sync.WaitGroup
mu sync.Mutex
findings []Finding
)
// Each manifest is checked in its own goroutine.
// Each goroutine bundles all the mismatches so that it can be queried later.
for _, m := range manifests {
mismatches, err := m.checker.Check("", string(m.content))
if err != nil {
continue // resolver/parse error on this file: fail open, keep scanning
}
for _, mm := range mismatches {
findings = append(findings, Finding{File: m.rel, Mismatch: mm})
}
wg.Add(1)
go func(m manifest) {
defer wg.Done()
mismatches, err := m.checker.Check("", string(m.content))
if err != nil {
return // resolver/parse error on this file: fail open, keep scanning
}
mu.Lock()
defer mu.Unlock()
for _, mm := range mismatches {
findings = append(findings, Finding{File: m.rel, Mismatch: mm})
}
}(m)
}
wg.Wait()

sort.Slice(findings, func(i, j int) bool {
if findings[i].File != findings[j].File {
Expand Down