refactor(ui): extract domain hooks and analytics wrappers - #54
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ui/hooks/use-search-flow.ts(search query, request/response, filters, pagination),ui/hooks/use-history.ts(history CRUD, paging, localStorage sync),ui/hooks/use-favorites.ts(local storage +/api/favoritessync, replace/remove helpers), andui/hooks/use-preferences.ts(storage, reset, serialization, derived reset state).ui/app/[locale]/page.tsxusesuseSearchFlowanduseHistory,ui/app/[locale]/favorites/page.tsxusesuseFavorites, andui/app/[locale]/preferences/page.tsxusesusePreferences.ui/lib/track.tsand added small wrapper functionstrackSearch,trackFavorite,trackCompare, andtrackDetailViewto standardize event payload construction used by pages.FAVORITES_STORAGE_KEYandPREFERENCES_STORAGE_KEYlogic into the corresponding hooks and removed duplicated state/IO from pages.Testing
cd ui && npm run typecheck, which completed successfully.cd ui && npm run lint, which failed due to a missing ESLint flat config (project lackseslint.config.*), so lint errors are unrelated to the introduced code shape.Codex Task