fix(ui): support both array and object recommend API responses - #64
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
recommendationsarray, so thesearchparser must handle both shapes to avoid runtime failures.Description
ui/hooks/use-search-flow.tsto read the rawpayloadviaawait response.json()cast asRecommendItem[] | { recommendations?: RecommendItem[] }and normalize arecommendationsarray by branching onArray.isArray(payload)orArray.isArray(payload?.recommendations), then map that normalized array into the existingnormalizedresults while keeping filtering, sorting, pagination, and telemetry behavior unchanged.Testing
npm run typecheckinui/and the TypeScript check completed successfully.Codex Task