Add documentation section on complex number handling#773
Draft
Technici4n wants to merge 3 commits intochalk-lab:mainfrom
Draft
Add documentation section on complex number handling#773Technici4n wants to merge 3 commits intochalk-lab:mainfrom
Technici4n wants to merge 3 commits intochalk-lab:mainfrom
Conversation
Collaborator
|
Thanks for this @Technici4n . I've taken the liberty of merging the latest changes from main into this branch, so that I can build the docs locally and review. Hope that's okay! |
Collaborator
Author
|
Of course, feel free to push anything! |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
@kshyatt would you be able to review this? |
Collaborator
Author
|
I need to clean it up first, once the tangent <-> primal conversions are done. :) |
yebai
force-pushed
the
main
branch
3 times, most recently
from
dfec3c4 to
7b2f7ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the handling of complex numbers in Mooncake. See #768 for the discussion that lead to this PR. Fixes #768.