Conversation
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
|
Mooncake.jl documentation for PR #856 is available at: |
|
Performance Ratio: |
|
I don't think that nightly is worth it, but we should add |
|
I agree, nightly is quite fragile. BTW, current nightly is 1.14. |
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
|
Note that pre is currently julia 1.12. Do we know when the first 1.13 pre will be released? |
|
Yeahhh, it's kind of in an awkward spot, that's why I haven't added 1.13 tests for the Turing repos. I'm not actually sure how to specify 1.13 in CI. Maybe 1.13.0-alpha1 was supposed to be released last week, but it didn't build: https://julialang.slack.com/archives/C7E3LFG82/p1763643474697259 |
|
1.13-alpha2 is released, so might be worth checking whether |
* Use conditional for interpreter selection based on version Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Add conditional inclusion for patch_for_319.jl Conditionally include patch_for_319.jl for versions below 1.12 Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Refactor local_interp initialization for version check Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com> --------- Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
dfec3c4 to
7b2f7ba
Compare
|
Frustratingly, we can't even start a CI run for 1.13 because JET won't install. See aviatesk/JET.jl#796 We should perhaps factor the JET tests out into a separate test suite that only runs if JET is installable. |
fff10c4 to
6f9eb9d
Compare
|
The test suite doesn't hard-depend on JET; if JET isn't installed, it will skip JET tests. This means one can temporarily remove JET from the test environment. Julia 1.13 appears to be less disruptive than 1.12, since some tests (e.g., linear_algebra) pass without change. This indicates the core compiler part may be mostly fine. |
2e12e88 to
d51bf3c
Compare
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Revert conditional JET loading (commit 69a06e0) and instead make @check_allocs a null op in MooncakeAllocCheckExt on Julia 1.13+. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
# Conflicts: # src/interpreter/ir_utils.jl # test/ext/nnlib/Project.toml
TODO
CI Summary — GitHub Actions
Documentation Preview
Mooncake.jl documentation for PR #856 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR856/
Performance
Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.