fix: expose background color & shadow customization, sync header support to BottomSheet#75
Open
MrRoy121 wants to merge 3 commits intochandrabezzo:mainfrom
Open
fix: expose background color & shadow customization, sync header support to BottomSheet#75MrRoy121 wants to merge 3 commits intochandrabezzo:mainfrom
MrRoy121 wants to merge 3 commits intochandrabezzo:mainfrom
Conversation
…Dialog`, and `SelectionBottomSheet`. * Allow users to provide a custom `List<BoxShadow>` to override the default dialog and bottom sheet styling. * Update `CountryCodePicker` to pass the `backgroundColor` and `boxShadow` properties to the selection components. * Set `elevation` to 0 in the default `Dialog` to favor custom `BoxDecoration`.
Specific changes include: - Added `hideHeaderText`, `headerText`, `headerTextStyle`, `topBarPadding`, `headerAlignment`, and `hideCloseIcon` properties to `CountryCodePicker` and `SelectionBottomSheet`. - Implemented a new header row in the bottom sheet to support optional titles and alignment configurations. - Added logic to toggle the visibility of the close icon.
- Exposed backgroundColor for Dialog and BottomSheet - Added customizable boxShadow support - Added header customization for BottomSheet
Author
|
@chandrabezzo Brother.. Please review it.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
What's fixed:
showModalBottomSheetbackground was hardcoded toColors.transparent— now useswidget.backgroundColorDialogbackground was uncontrolled — now passesbackgroundColorandelevation: 0soSelectionDialogfully owns its visualsboxShadowparam to bothSelectionDialogandSelectionBottomSheet— pass[]to remove shadow, or provide fully custom shadowsheaderText,headerTextStyle,hideHeaderText,topBarPadding,headerAlignment,hideCloseIcon) — defaults to no header to keep existing behavior unchangedUsage: