Harden .gitignore for runtime data#97
Open
chansg wants to merge 1 commit into
Open
Conversation
Runtime data leaked into commits three times (data/broker, data/trading, data/notifications.jsonl) because data/ was only partially ignored. Replace the scattered rules with one blanket rule and untrack the runtime files still in the index. Files are removed from the git index only (--cached); they remain on disk. - .gitignore: data/* + !data/.gitkeep (covers all current and future runtime files) - data/.gitkeep: placeholder so the folder survives a fresh clone - Untracked: data/personality.json (runtime mood/interaction state) and the stale data/market/.gitkeep — both kept on disk. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Close the runtime-data leak permanently with a single blanket ignore rule, and untrack the runtime files still tracked in the index — without deleting any local data.
Why
Runtime files leaked into commits three times (
data/broker/,data/trading/,data/notifications.jsonl) becausedata/was only partially ignored, anddata/personality.jsonshowed as modified every session (Aria rewrites it at runtime).Changes
.gitignore: replaced the scattered per-path rules with one blanket rule — ignore everything underdata/, except a.gitkeepplaceholder.data/.gitkeep: placeholder so the folder survives a fresh clone.--cached— still on disk):data/personality.json(runtime mood/interaction state) and the staledata/market/.gitkeep.Safety
git rm --cached. Confirmeddata/personality.jsonand all runtime files still physically present.git check-ignore config.py .envreturns both.Leak test
Recreated the exact failure scenario (create a fake
notifications.jsonl, thengit add -A). Result: nothing staged — the runtime file is silently ignored. Leak closed.🤖 Generated with Claude Code