Repository navigation
ci: add Platform Doctor scan and address platform findings - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pinned Platform Doctor scan to pull-request and main-branch CI, publishing its report as an artifact and job summary. Critical findings fail the job.
Address applicable findings by running the container as UID/GID 10001, checking that identity in the Docker smoke test, defaulting workflows to read-only permissions, and isolating release publishing and E2E failure reporting in separate jobs. Remove unused package write access and update the release action to v2. Add a maintainer runbook covering CLI/container recovery and explaining why hosted-service cloud budgets do not apply to Netkit.
Validation: actionlint and git diff --check pass. Local Platform Doctor exits successfully at 76/100 with zero critical findings; its two remaining warnings flag the necessary job-scoped contents/ issues write permissions. Docker runtime validation could not run because the local Docker daemon is stopped.