Repository navigation
Allow long polling through HTTPS inspection - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspection transport's fixed 30-second response-header timeout returns 502 for APIs that legitimately long-poll for 30 seconds. Remove that fixed deadline by default and expose
--inspection-response-header-timeoutfor users who want a finite limit. Client cancellation, TLS handshake deadlines, and idle connection limits still apply.Add regression coverage for delayed headers, explicit deadline enforcement, body capture, and configuration propagation.
NETKIT_LONG_POLL_TEST=1runs the polling scenario with a real 31-second wait.Validation: full
make ci, final lint and configuration checks, and the 31-second polling regression with the race detector.