Repository navigation
Conversation
chaoz23
marked this pull request as ready for review
October 23, 2026 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current-main review — 2026-10-23
Exact head:
fad792203872d6089cebc22bfbef1041cc5b047aTree:
6a6e5c462ac568230d7d152c24c249e9e29054e5Base/current main:
3ca408274d3ac321e79801e0b4c0e3cab10c764bMerged main into the original branch without rewriting
539d235eor its historical evidence. The branch is three commits ahead and zero behind main. Independent ledger, CLI/contract, and session/policy reviews found no actionable defects; original telemetry source and tests are unchanged.The fresh dependency audit exposed two high advisories: body-parser compressed trailing bytes and Zod oversized collections. A narrow fix raises the Zod floor to
^4.6.6(locked4.6.7), locks body-parser2.4.0, and takes its required content-type2.1.0update. No unrelated dependency refresh or search-policy change.Fresh validation
Current-head matched calibration
Compared exact current main with exact candidate, each independently installed from its own committed lock. This measures the combined candidate and dependency delta, not causal telemetry-only overhead. The unchanged September calibration remains historical evidence, not the current readiness result.
Protocol: authored Intercept, shared search, one core, depth 100, 50,000 states, search seed 7/story seed 1, 2 GiB process heap, no minimum reproduction, progress off, ordinary JSON; one excluded B-C warmup pair followed by four serial counterbalanced B-C/C-B/B-C/C-B pairs. Before and after every arm, the harness freezes clean HEAD/tree/source, all built JavaScript, dependency installations/locks, runtime, compiler, story, and measurement code.
Paired medians: wall +3.883%, RSS +7.205%. Worst positive pairs: wall +4.939%, RSS +16.443%. RSS is noisy: both +12.998% and +16.443% pairs are retained, not excluded. The preregistered ratio-of-medians gates are primary; this is not a claim of absolute neutrality, improved speed, or improved memory use.
All ten arms produced identical canonical output after stripping only
resources.longRunTelemetry: 50,000 states / 297 endings / 29 visited knots / zero runtime errors / maxStates-only truncation. Candidate telemetry identities and transition projection were stable; all frozen inputs stayed unchanged. Raw calibration SHA-256:c881e2153d5464b7eb81eb6a00a2f3fd6909e641ad25ee4c0f661963d6bc7273; harness SHA-256:0077fc77e5f781e2870c27f4ad94e86032e9336f42c7b62740fc3ccf8567f1c4. Raw results, harness, logs, audit, and pack receipt are preserved in the local October 23 readiness handoff.Boundaries and next proof step
Telemetry is observational and is not read by allocation, knee, forecast, shadow-policy, frontier, or stopping decisions. Collection has bounded overhead and can move an execution already beside a memory/time guard.
This remains partial #216 work. Checkpoint/epoch/generic-pressure boundaries, complete exclusive-owner attribution, policy activation, default changes, InkBench promotion, and release publication remain out of scope. No issue is closed by this PR.
After merge, bridge the validated cost/phase records into InkBench's adapter/report schema, which currently ignores
longRunTelemetry; preserve sample bounds/units, overlapping inclusive phases, and pass-local identities without inventing CPU/peak-RSS data. Most InkBench validity infrastructure already shipped, so do not recreate it from stale issue comments. Finish the meaningful #190/#217/#218 long-run candidate and remaining #216 accounting before #219's frozen fresh 20-minute promotion matrix; never resume the historical 60-minute matrix. This readiness calibration is not an InkBench proof point.Related: #216, #215