chore: drop the tablekit SCHEMA_NOT_FLAG waiver - #87
Merged
Merged
Conversation
table-kit is adding --schema as a flag alias (chaoz23/table-kit#23). The waiver has to come out before the fix lands, not after: the ratchet fails a waiver that no longer fires, so a fixed tool still carrying its waiver goes red with STALE BASELINE. Ordering across the two repos, which the SHA pin makes safe: 1. this PR removes the waiver -> srdcheck CI unaffected (it audits only itself); table-kit CI still pins the old SHA, so it keeps the old baseline and stays green 2. table-kit fixes --schema AND bumps -> new baseline, rule no longer fires, its pin in the same PR green Without the pin these two repos could not be changed independently at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares chaoz23/table-kit#23. First burn-down of the #86 baseline.
Why this lands first
The ratchet fails a waiver that no longer fires. So a fixed tool still carrying its waiver goes red with
STALE BASELINE— the waiver has to come out before the fix, not after.The SHA pin is what makes the two repos independently changeable:
--schemais a subcommand, not the flag clause 7 codifies table-kit#23 adds the--schemaalias and bumps its pin in the same PR → new baseline, rule no longer fires, greenWithout the pin, removing a waiver here would immediately redden table-kit's CI before its fix existed. That constraint wasn't obvious when the pin was chosen for a different reason — it turns out to be what makes cross-repo ratcheting workable at all.
Verified: srdcheck self-check still exits 0.
🤖 Generated with Claude Code