CbParsleyDriver: several improvements for error handling and logging#63
Draft
CbParsleyDriver: several improvements for error handling and logging#63
Conversation
When a safety error was raised during charging, let's tell EvseManager about the state chance on CE line. While at, also improve the error message when state F is requested. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
We can filter out some messages to improve readability of the overall logs. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
We cannot convert PilotFaults to a BSP event, so let's exit early here. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
In case of CE malfunction error, try to recover when an ID state change is detected. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
lategoodbye
reviewed
May 7, 2026
Contributor
|
I have a further possible improvement for logging. I get the warning But this should only come when PowerOn is detected twice: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bundles several small fixes, see commit messages for details.