Optisyntax#42
Conversation
| downward loop, for example: | ||
|
|
||
| ```optilambda | ||
| for<seq> i in n..0:-1 |
There was a problem hiding this comment.
Didn't we decide that it was better to use range(n, 0, -1) when the step was not trivial? Or was it for contracts?
There was a problem hiding this comment.
that was the plan. @Ultra-MG did you take inspiration from a specific language with this syntax ?
There was a problem hiding this comment.
i did not take inspiration from any language i just thought it made sense to have it this was but if you prefer the range one i can change it, it is a simple change. Just let me know if it is a necessary change
yannilefki
left a comment
There was a problem hiding this comment.
I don't see any issue with the code itself. I did not try to use it, but it seemed to work well when I came to check it out.
Overall, I would recommand 3~ish lines headers for every new file, describing what the file is doing, its interactions with the framework, and what problem it is solving.
Bastacyclop
left a comment
There was a problem hiding this comment.
Thanks for the PR @Ultra-MG !
This looks good to me. We can merge once you address the minor comments that were raised. I think Arthur also requested some tweaks, so let me know if you want to integrate the tweaks in this PR or in a follow-up one.
Summary
This PR completes the optisyntax branch work.
Main changes:
Notes: