fix: build and verify the unpacked Linux app - #22
Closed
charliebarmore wants to merge 1 commit into
Closed
charliebarmore wants to merge 1 commit into
charliebarmore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run package:dirfailed on Linux because the fuse hook openedLedgerPDF, but electron-builder created a different executable name. The build now explicitly names the Linux binaryledgerpdf, the hook uses the packager's actual name, and package verification resolves Linux output directories instead of a Windows EXE.The packaged smoke test now imports two PDFs, a receipt image, and a two-sheet workbook, exports all nine pages through the frozen engine, and requires nine pages after reopening the saved binder. A manual
packageoption in the Linux workflow builds and verifies the unpacked app under Xvfb; ordinary PRs keep source-only checks. Documentation records the test scope and remaining limits.Validation on Omarchy / Arch Linux x64, Node 26.7.0, Python 3.14.7:
npm run package:dirpassed after reproducing and fixing the original failure.npm run verify:packagepassed: nine fuse settings, resources/licenses, frozen engine, mixed import/export/reopen, and packaged MCP with approved-folder enforcement.git diff --checkpassed.The walkthrough used agent-browser against the normal packaged window, not a human acceptance test. Native file dialogs, installers/desktop registration, ARM builds, and portability of Arch-built binaries remain unverified. Details:
docs/LINUX-VERIFICATION.md.Follow-up to #20 and #21.
Clean-runner validation: Linux packaging run passed on Ubuntu 22.04 with Node 22 and Python 3.12 at commit
44aabd3, including nine fuse settings, frozen engine, nine-page mixed import/export/reopen, and packaged MCP. All PR source checks on Linux, Windows, and macOS plus CodeQL passed.