feat(config): allow env var CATWALK_PORT to override the port#342
Open
meowgorithm wants to merge 1 commit into
Open
feat(config): allow env var CATWALK_PORT to override the port#342meowgorithm wants to merge 1 commit into
meowgorithm wants to merge 1 commit into
Conversation
andreynering
approved these changes
Jun 11, 2026
Comment on lines
+83
to
+85
| type config struct { | ||
| Port int `env:"CATWALK_PORT" envDefault:"8080"` | ||
| } |
Member
There was a problem hiding this comment.
Not a big deal at all, but for a single simple env, stdlib would also be fine:
port := cmp.Or(os.Getenv("CATWALK_PORT"), "8080")
Member
Author
There was a problem hiding this comment.
Yeah, my thought here was to set this up as a best practice for future env var management, but to be fair this is indeed a premature optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the port to be overridden with
CATWALK_PORTin the environment.